From: Simon McVittie <smcv@debian.org>
Date: Sun, 30 Oct 2016 13:52:51 +0000 (+0000)
Subject: load_metadata_internal: don't leak GBytes
X-Git-Tag: archive/raspbian/2022.1-3+rpi1~1^2~4^2~44^2~13
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8ae03d6497db35b8d34be590d770e6d92beec9c6;p=ostree.git

load_metadata_internal: don't leak GBytes

Found by valgrind memcheck. g_variant_new_from_bytes takes a ref to the
bytes, so we need to release the original ref.

Signed-off-by: Simon McVittie <smcv@debian.org>

Closes: #556
Approved by: cgwalters
---

diff --git a/src/libostree/ostree-repo.c b/src/libostree/ostree-repo.c
index 2e35faf8..1f866bbe 100644
--- a/src/libostree/ostree-repo.c
+++ b/src/libostree/ostree-repo.c
@@ -2593,7 +2593,7 @@ load_metadata_internal (OstreeRepo       *self,
             }
           else
             {
-              GBytes *data = glnx_fd_readall_bytes (fd, cancellable, error);
+              g_autoptr(GBytes) data = glnx_fd_readall_bytes (fd, cancellable, error);
               if (!data)
                 goto out;
               ret_variant = g_variant_new_from_bytes (ostree_metadata_variant_type (objtype),